fst.ext.determinize_star wrapping might be wrong

[Ithilan]

According to https://kaldi-asr.org/doc/group__fst__extensions.html#gac6d4823e83f5353ae5b5ce569a7a29a3
The boolean returned by determinzestar is False on success
Caution, the return status is un-intuitive: this function will return false if determinization completed normally, and true if it was stopped early by reaching the 'max-states' limit, and a partial FST was generated.

However in the pykaldi implementation we can see that the treatment is incorrect

   ofst = _fst.StdVectorFst()
    success = _special_ops._determinize_star(ifst, ofst, delta, max_states,
                                             allow_partial)
    if success:
        return ofst
    else:
        raise RuntimeError("Determinization failed.")

from https://github.com/pykaldi/pykaldi/blob/master/kaldi/fstext/special.py

It should be if not success

[bmilde]

That seems to be the correct interpretation according to the docu, did you try this out and did you encounter a RuntimeError where you basically shouldn't?