pygbag cli: --directory and --cache arguments are not respected

[gabriel-v]

Parser args are added here:

• pygbag/pygbag/app.py

  Lines 185 to 189 in 17ae938

  	parser.add_argument(
  	"--directory",
  	default=build_dir.as_posix(),
  	help="Specify alternative directory [default:%s]" % build_dir,
  	)

• pygbag/pygbag/app.py

  Line 214 in 17ae938

  parser.add_argument("--cache", default=cache_dir.as_posix(), help="md5 based url cache directory")

But then, they are not being used at all, here:

• pygbag/pygbag/app.py

  Line 296 in 17ae938

  build_dir={build_dir}

  (should be args.directory)

• pygbag/pygbag/app.py

  Line 337 in 17ae938

  nonlocal cache_dir

  (should be args.cache)

• pygbag/pygbag/app.py

  Lines 129 to 131 in 17ae938

  	cache_root = app_folder.joinpath(CACHE_ROOT)
  	cache_dir = app_folder / CACHE_PATH
  	build_dir = app_folder / CACHE_APP

  (should read from args, not set as app.folder / build)

I think we need to either remove the arguments or respect them.

My current workaround for this issue is to cp -a the stuff into a temporary directory before building.

[pmp-p]

Thank for reporting.
Indeed commenting them until implemented correctly as they are confusing, and "build" is totally fine for python ecosystem anyway.