-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is Chardet a dependency? #272
Comments
When searching for "chardet" in your whole organization I find a single occurence of chardet actually being used in python code:
Did you maybe forget to move chardet to the requirements.txt for pyexcel-io? it's not in there. |
@chfw if you have some spare time it would be really appreciated if you could take a look at this one |
@chfw I think I know what happened: I think you then added chardet to pyexcel/pyexcel, but this code is only used by pyexcel/pyexcel-io. I think it should have been added as a requirement for that package and not toplevel on pyexcel/pyexcel. Our problem is that we (currently I work for a corporate fin. comp) can not use LGPL packages, so we can not use chardet. To fix this:
|
Because of strict licensing regulations at our company we can not use pyexcel, because chardet has the LGPL license.
Upon inspection I see that nowhere the chardet library is imported. When I clone this project, switch to v0.7.0 branch and remove the chardet depdendency everywhere, I can run a succesfull test suite.
Can chardet be removed or is there a reason that chardet has to remain as a dependency of pyexcel?
The text was updated successfully, but these errors were encountered: