Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchdog omitted in requirements.txt #45

Closed
dhnam opened this issue Sep 16, 2023 · 4 comments
Closed

watchdog omitted in requirements.txt #45

dhnam opened this issue Sep 16, 2023 · 4 comments

Comments

@dhnam
Copy link

dhnam commented Sep 16, 2023

Module watchdog is needed in dynamical reloading, but is omitted in requirements.txt.

@jamesdbrock
Copy link
Member

watchdog is in the Poetry dev dependencies.

pyedifice/pyproject.toml

Lines 20 to 36 in 9db36e8

[tool.poetry.group.dev.dependencies]
certifi = ">= 2020.12.5" # "^2023.5.7"
chardet = ">= 4.0.0" # "^5.1.0"
idna = ">= 2.10" # "^3.4"
pandas = ">= 1.2.0" # "^2.0.3"
PyQt6 = ">= 6.0" # "^6.5.1"
PyQt6-sip = ">= 13.0.0" # "^13.5.1"
PySide6 = ">= 6.0.0" # "^6.5.1.1"
shiboken6 = ">= 6.0.0" # "^6.5.1.1"
six = ">= 1.15.0" # "^1.16.0"
snowballstemmer = ">= 2.0.0" # "^2.2.0"
pytz = ">= 2020.5" # "^2023.3"
requests = ">= 2.25.1" # "^2.31.0"
watchdog = ">= 1.0.2" # "^3.0.0"
urllib3 = ">= 1.26.2" # "^2.0.3"
python-dateutil = ">= 2.8.1" # "^2.8.2"
matplotlib = ">= 3.3.3" # "^3.7.2"

@dhnam
Copy link
Author

dhnam commented Sep 20, 2023

Aha... I just installed pyedifice with pip and watchdog is not installed with it, so I had to manually install it via pip.

@jamesdbrock
Copy link
Member

watchdog is not installed with it, so I had to manually install it via pip.

That seems like a good solution? Or we could have a dev-requirements.txt? https://stackoverflow.com/questions/63243532/how-to-avoid-putting-dev-packages-in-requirements-txt

@dhnam
Copy link
Author

dhnam commented Sep 22, 2023

Guess adding 'You should install watchdog to use dynamic reload' in readme.txt and tutorial about dynamic reload would be good way to go, I believe (when avoiding adding watchdog to requirement.txt)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants