Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: If running on a notebook server, check if running on localhost #26

Open
tswast opened this issue Apr 23, 2019 · 2 comments
Open

ENH: If running on a notebook server, check if running on localhost #26

tswast opened this issue Apr 23, 2019 · 2 comments
Labels
type: feature request 'Nice-to-have' improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Collaborator

tswast commented Apr 23, 2019

If it's on localhost, it could default to use the nicer web server auth flow.

@tswast tswast added the type: feature request 'Nice-to-have' improvement, new feature or different behavior or design. label Jun 28, 2019
@abdelmegahed
Copy link

+1

creds = pydata_google_auth.get_user_credentials(scopes=SCOPES) now fails when getting executed from a machine without a browser (such as a notebook) after the deprecation of OOB.

This is because the default is to use local server and the local server expects the OAuth flow to be executed in the current host (which isn’t possible since there isn’t a browser). This wasn't the issue before, as with OOB the local server was simply waiting to get a token (and the flow could be done on another host).

I think there are two approaches to this:

  1. Set use_local_webserver=False by default and let the proxy handle the traffic.
  2. Check if there is browser installed (as done in the gcloud SDK) and route to proxy if there isn't.

@abdelmegahed
Copy link

I hope that my comment is within context for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request 'Nice-to-have' improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants