[BUG] Four potential memory leaks due to refcnt not decreased on error branches. (Static analysis reports)

[Snape3058]

Describe the bug
During module initialization, the call to macro import_array will return NULL directly on failure, which will make the created module leaked without decreasing its refcnt.

Bug path trace

move_template.c

1. Module is created, pointed to by m.
   

   bottleneck/bottleneck/src/move_template.c

   Line 1504 in f2bc792

   PyObject *m = PyModule_Create(&move_def);

2. Assume m is not NULL.
   

   bottleneck/bottleneck/src/move_template.c

   Line 1508 in f2bc792

   if (m == NULL) return RETVAL;

3. Invoke macro import_array, assume error happens and NULL is returned directly.
   

   bottleneck/bottleneck/src/move_template.c

   Line 1509 in f2bc792

   import_array();

4. The module pointed to by m leaks without decreasing its refcnt.

Similarly, it is the same symptom in another three files.

• nonreduce_axis_template.c
  

  bottleneck/bottleneck/src/nonreduce_axis_template.c

  Line 1054 in f2bc792

  PyObject *m = PyModule_Create(&nra_def);

  
  

  bottleneck/bottleneck/src/nonreduce_axis_template.c

  Line 1058 in f2bc792

  if (m == NULL) return RETVAL;

  
  

  bottleneck/bottleneck/src/nonreduce_axis_template.c

  Line 1059 in f2bc792

  import_array();

• nonreduce_template.c
  

  bottleneck/bottleneck/src/nonreduce_template.c

  Line 369 in f2bc792

  PyObject *m = PyModule_Create(&nonreduce_def);

  
  

  bottleneck/bottleneck/src/nonreduce_template.c

  Line 373 in f2bc792

  if (m == NULL) {

  
  

  bottleneck/bottleneck/src/nonreduce_template.c

  Line 376 in f2bc792

  import_array();

• reduce_template.c
  

  bottleneck/bottleneck/src/reduce_template.c

  Line 2545 in f2bc792

  PyObject *m = PyModule_Create(&reduce_def);

  
  

  bottleneck/bottleneck/src/reduce_template.c

  Line 2549 in f2bc792

  if (m == NULL) return RETVAL;

  
  

  bottleneck/bottleneck/src/reduce_template.c

  Line 2550 in f2bc792

  import_array();

Version

Static analysis carried out on commit f2bc792.