Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add functions that extend anynan for non-finite values #374

Open
Skylion007 opened this issue Jan 30, 2021 · 1 comment
Open

Comments

@Skylion007
Copy link

Skylion007 commented Jan 30, 2021

This package is very appealing for the accelerated anynan,allnan etc functions. There is a common use case that this package is failing to consider though. And that is that following common numpy structure:

assert np.all(np.isfinite(arr))

We may want to exclude inf and -inf as well as NaNs from the input. Would it be possible to add additional functions to this package that can do so? Or alternatively parameterize existing functions to enable this functionality with similar high-performance to anynan / allnan ?

@Skylion007 Skylion007 changed the title [Enhancement] Add functions that extend anyNaN for non-finite values [Enhancement] Add functions that extend anynan for non-finite values Jan 30, 2021
@jbrockmendel
Copy link

I came here to request the same thing; found that in pandas we do np.isfinite(arr).all() and it'd be nice to short-circuit. (see also pandas-dev/pandas#32339)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants