You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found that the nonreduce_axis.push only support dtypes compatible with np.nan, or for which np.isnan is supported.
I'd be happy to attempt to extend the range to other types and submit a PR.
But before I do that would like to know whether such a PR will be considered and what else do I need to know?
I came accross this behavior from xarray.ffill, where I wanted to forward fill string-array, but it failed.
The text was updated successfully, but these errors were encountered:
@kefirbandi Absolutely would be considered given it's already in our API and there's no real equivalent in numpy. I'd suggest benchmarking any solution you have against pandas and make sure we're not slower. We'll want hypothesis testing on a variety of object types to make sure behavior is correct.
I found that the nonreduce_axis.push only support dtypes compatible with np.nan, or for which np.isnan is supported.
I'd be happy to attempt to extend the range to other types and submit a PR.
But before I do that would like to know whether such a PR will be considered and what else do I need to know?
I came accross this behavior from xarray.ffill, where I wanted to forward fill string-array, but it failed.
The text was updated successfully, but these errors were encountered: