Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQMQA support: overriding ternary extrapolations defined in the chemical groups #402

Open
bocklund opened this issue Mar 22, 2022 · 0 comments
Labels

Comments

@bocklund
Copy link
Collaborator

Our MQMQA implementation uses chemical groups to decide how to extrapolate binary excess parameters in ternary systems. ChemSage DAT files seem to have syntax that allows users of the MQMQA to override the ternary extrapolation, as discussed in this thread on #389.

PR #389 introduced some support to parse these "overrides" into some simple data structures (pycalphad.io.cs_dat._process_chemical_group_override_string) so we can report warnings to users of these models that the extrapolated energies may be incorrect.

We should use these (or create new) data structures for these overrides and enter them into the phase models hints so they can be used with the ModelMQMQA._chemical_group_filter method to apply the overridden categorization of elements into nu or gamma (see ModelMQMQA.excess_mixing_energy or ModelMQMQA._Chi_mix) to give correct extrapolation behavior.

@bocklund bocklund added the bug label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant