Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collapse_nodes does not apply to members of ListAbundance #480

Open
ddomingof opened this issue Jan 14, 2021 · 3 comments · May be fixed by #481
Open

collapse_nodes does not apply to members of ListAbundance #480

ddomingof opened this issue Jan 14, 2021 · 3 comments · May be fixed by #481
Assignees
@cthoyt
Labels
bug

Comments

@ddomingof
Copy link
Member

I noticed that if you apply collapse_nodes is not being applied to the members of ListAbundance (reactions, complexes...)
@ddomingof ddomingof added the bug label Jan 14, 2021
@cthoyt
Copy link
Member

cthoyt commented Jan 14, 2021

Oof that’s a good catch, since those types of nodes store extra copies of the nodes

@ddomingof
Copy link
Member Author

Is this on your radar? Cause I would say it's a bad bug

@cthoyt
Copy link
Member

cthoyt commented Jan 23, 2021

I wrote unit tests for it a few days ago but no implementation yet. I'll make a draft PR, you can add an implementation if this is urgent

cthoyt added a commit that referenced this issue Jan 23, 2021
@cthoyt
Add first test for collapsing list abundances
16c61f1 
References #480
@cthoyt cthoyt linked a pull request Jan 23, 2021 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthoyt cthoyt

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix collapse algorithm on list abundances pybel/pybel
2 participants
@cthoyt @ddomingof