Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some [source] links in the docs do not work #981

Open
kbattocchi opened this issue Jul 18, 2023 · 2 comments
Open

Some [source] links in the docs do not work #981

kbattocchi opened this issue Jul 18, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@kbattocchi
Copy link
Contributor

For example, in the datasets submodule, the [source] links next to at least lalonde_dataset, partially_linear_dataset, and psid_dataset all point to anchors that do not exist on the corresponding datasets source page (and the methods do not appear to be defined within that source at all).

Perhaps relatedly, it looks like some numpy methods are also being re-exported in the datasets module - choice and random, the former of which looks very strange in the documentation here since it says it's new as of version 1.7.0 which makes sense for numpy but not for dowhy; these entries don't have source links at all.

@kbattocchi kbattocchi added the bug Something isn't working label Jul 18, 2023
@amit-sharma
Copy link
Member

amit-sharma commented Jul 23, 2023

Thanks for flagging this @kbattocchi These datasets do exist in datasets.py. I suspect some kind of caching during docs build that is leading to these incorrect results.
@bloebp any idea? The numpy.choice mixup is rather strange.

@bloebp
Copy link
Member

bloebp commented Aug 14, 2023

Hey, sorry I missed this before.

It is indeed strange and I don't see an obvious reason for these things. In 0.10, the source links are working, but not on main.

When building the documentation there is, however, a long list of issues and warnings, maybe it is time to go through this one by one. I can give it a shot, but can't promise when (it will definitely take some time to fix all of it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants