Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency parameter in independence_test_method #151

Open
priamai opened this issue Nov 16, 2023 · 1 comment
Open

Consistency parameter in independence_test_method #151

priamai opened this issue Nov 16, 2023 · 1 comment

Comments

@priamai
Copy link

priamai commented Nov 16, 2023

I noticed that for example the CDNOD calls them:
indep_test: Independence test method function. Default: ‘fisherz’.
But FCI:
independence_test_method: Independence test method function. Default: ‘fisherz’.

I think we should unify all the methods to use the same keyword?
Cheers.

@kunwuz
Copy link
Collaborator

kunwuz commented Dec 5, 2023

Yeah, this is definitely something on the list. We will improve the APIs shortly. Thanks for your suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants