Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC algorithm logic #129

Open
kenneth-lee-ch opened this issue Aug 14, 2023 · 3 comments
Open

PC algorithm logic #129

kenneth-lee-ch opened this issue Aug 14, 2023 · 3 comments

Comments

@kenneth-lee-ch
Copy link
Contributor

In the causal-learn/causallearn/utils/PCUtils/SkeletonDiscovery.py, why does it need to add sepsets to cp.sepset at lines 123-124? If the p-value return at line 101 is not greater than alpha for all S in line 100, doesn't that mean you force an empty set to be a separating set?

@kunwuz
Copy link
Collaborator

kunwuz commented Aug 26, 2023

Yes, and it is consistent with the pseudo-code of PC, where an empty set could be a separating set.

@kenneth-lee-ch
Copy link
Contributor Author

I mean you will infer d-separation with respect to an empty set regardless of the test result.

@kunwuz
Copy link
Collaborator

kunwuz commented Jan 23, 2024

Thanks for the explanation. @zhi-yi-huang tried to fix this issue in #161 (thanks so much!). Please let us know if there are any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants