Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITE] If we find SW in initial fast API call but timeout on second, rely on the first result #4553

Open
Jaylyn-Barbee opened this issue Nov 30, 2023 · 1 comment
Assignees

Comments

@Jaylyn-Barbee
Copy link
Contributor

Jaylyn-Barbee commented Nov 30, 2023

The problem:
The fast API call scrapes HTML to look for a SW. Sometimes this will return true for has_service_worker but the second API waits for the page to load and for large sites, this can cause the SW api to timeout.

Right now, the second call of "no service worker" is overriding the first API response.

The solution:
If the fast test returns true but the second test times out, we should reuse the HTTPS yellow warning banner to communicate the following general message: "We detected a link to your service worker however, our tests timed out waiting for it to be registered. This can happen for a number of reasons and may even be intentional. To learn more about site load times and when you should be registering your service worker, follow the link below."

That copy isn't final but that's the general idea. The "learn more" link would either to internal documentation or an appropriate external resource.

@beth-panx
Copy link
Contributor

related #4552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo 📃
Development

No branches or pull requests

2 participants