Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manifest Editor] Screenshot Generation Temporal Solution #4550

Open
1 of 3 tasks
khmyznikov opened this issue Nov 29, 2023 · 0 comments
Open
1 of 3 tasks

[Manifest Editor] Screenshot Generation Temporal Solution #4550

khmyznikov opened this issue Nov 29, 2023 · 0 comments
Assignees
@khmyznikov @Jaylyn-Barbee @zateutsch
Labels
documentation feature request 📬 site

Comments

@khmyznikov
Copy link
Contributor

khmyznikov commented Nov 29, 2023 •
edited by Jaylyn-Barbee

Tell us about your feature idea

We need to close asap problem we created: large manifest files with base64 strings.
Developers don't understand why it's bad pattern and rely on our expertise.
What's happening from this: PWAs with 3-6Mb manifest file.

We have plans to revamp and fix this experience, but obviously there's no resources for now to fully dig into it, especially considering relatively small usage of this experience (>500 monthly clicks).

Do you have an implementation or a solution in mind?

  • completely close current "generate screenshots" feature (but keep existing screenshots preview)
  • create docs/article about how to easily do screenshots in DevTools (and optimize them in Squoosh)
  • provide link to this article with other hints to current screenshots tab

Have you considered any alternatives?

No response
@Jaylyn-Barbee Jaylyn-Barbee mentioned this issue Dec 6, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 7, 2023
@Jaylyn-Barbee
Transparent new default for Windows Icon Backgrounds. (#4571)
ccf6cdc 
fixes #4401
<!-- Link to relevant issue (for ex: "fixes #1234") which will
automatically close the issue once the PR is merged -->

## PR Type
<!-- Please uncomment one ore more that apply to this PR -->

<!-- - Bugfix -->
Feature
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## Describe the current behavior?
<!-- Please describe the current behavior that is being modified or link
to a relevant issue. -->
Manifest background color is default for icon background

## Describe the new behavior?
Transparent is default for icon background

## PR Checklist
- [x] Test: run `npm run test` and ensure that all tests pass
- [x] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [x] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.

## Additional Information
This PR also disables the ability to generate screenshots as we feel
generating base64 strings into peoples manifest is creating an
inefficient system and people don't understand why its inefficient and
trusting that PWABuilder is doing the right thing when it isn't. Part of
the temporary solution described here
#4550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khmyznikov khmyznikov

@Jaylyn-Barbee Jaylyn-Barbee

@zateutsch zateutsch

Labels
documentation feature request 📬 site
Projects
PWABuilder
Status: In Progress 🚧
Milestone
No milestone
Development

No branches or pull requests
3 participants
@khmyznikov @Jaylyn-Barbee @zateutsch