Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows 10] Discord RPC stays active even when TIDAL is paused or closed #29

Open
twhitson opened this issue May 20, 2020 · 10 comments
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@twhitson
Copy link

Steps to reproduce

  • Pause or close the TIDAL app

Actual behavior

Discord still says "Playing TIDAL"

Expected behavior

Discord RPC should go away when nothing is playing, or especially when the TIDAL app is closed completely.

@purpl3F0x
Copy link
Owner

Hello,
Yeah that seems to be an issue when moved to discord SDK.
(on Pause the behavior is as expected - it displays the song is closed)

@PaulBGD when disabled or tidal is not running

manager->clear_activity(manager, nullptr, nullptr);

is not sufficient - it just clears the rpc. Can you fix that ?
Idk the sdk maybe with something like that ?? app.core->destroy??;

@purpl3F0x purpl3F0x added bug Something isn't working help wanted Extra attention is needed labels May 21, 2020
@PaulBGD
Copy link
Contributor

PaulBGD commented May 21, 2020 via email

@purpl3F0x
Copy link
Owner

🙏🙏

@purpl3F0x
Copy link
Owner

Is this fixed ?

@jthvai
Copy link

jthvai commented Feb 3, 2022

Discord still says "Playing TIDAL" when TIDAL is completely closed. Running v1.3.0.79.

@pl4nty
Copy link

pl4nty commented Feb 5, 2022

The IDiscordCore instance should be destroyed per the docs. Could do it on pause (like Spotify), or just when Tidal is closed

@purpl3F0x
Copy link
Owner

If someone wants to implement it, I have no time atm. The app doesn't use the c++ bindings it's in C. The allocations and de-allocations should be done manually.

@bonklebum
Copy link

Still having this issue, any way to fix it yet?

@Schmiddisen
Copy link

This seems to be resolved in #100

@ungive
Copy link

ungive commented Mar 17, 2024

My pull request in #100 fixes this issue.

You can find a download on the releases page of my fork here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants