default and default-ssl vhosts are managed unconditionally

[wywerne]

Parameters default_vhost & default_ssl_vhost are set to false but I have "Duplicate declaration: Apache::Vhost[default] is already declared at (file: /data/puppet/code/modules/apache/manifests/init.pp, line: 853); cannot redeclare..." If I declare a default vhost with the apache::vhost function

In init.pp :

In hiera data :

Can you add in init.pp :

  Boolean $create_default_vhost   = true,
...
    if $create_default_vhost {
      ::apache::vhost { 'default':
...
      }
      $ssl_access_log_file = $::osfamily ? {
        'freebsd' => $access_log_file,
        default   => "ssl_${access_log_file}",
      }
      ::apache::vhost { 'default-ssl':
...
      }
    } 

Regards,

[ThomasMinor]

So using another name for the default host is not an option for you?

[ekohl]

The apache class has a parameter default_vhost which you can set to false. Then it doesn't create a default one.

[wywerne]

This param default_vhost is used in :
$default_vhost_ensure = $default_vhost ? {
true => 'present',
false => 'absent'
}
and the result is that the resource "::apache::vhost { 'default':" is defined but absent and unusable

[ekohl]

Ah, now I get it. I'm going to rephrase the issue so I understand it.

In the following code the vhosts default and default-ssl are always defined:

puppetlabs-apache/manifests/init.pp

Lines 842 to 883 in c26ca5d

	$default_vhost_ensure = $default_vhost ? {
	true => 'present',
	false => 'absent'
	}
	$default_ssl_vhost_ensure = $default_ssl_vhost ? {
	true => 'present',
	false => 'absent'
	}
	::apache::vhost { 'default':
	ensure => $default_vhost_ensure,
	port => 80,
	docroot => $docroot,
	scriptalias => $scriptalias,
	serveradmin => $serveradmin,
	access_log_file => $access_log_file,
	priority => 15,
	ip => $ip,
	logroot_mode => $logroot_mode,
	manage_docroot => $default_vhost,
	use_servername_for_filenames => true,
	use_port_for_filenames => true,
	}
	$ssl_access_log_file = $facts['os']['family'] ? {
	'FreeBSD' => $access_log_file,
	default => "ssl_${access_log_file}",
	}
	::apache::vhost { 'default-ssl':
	ensure => $default_ssl_vhost_ensure,
	port => 443,
	ssl => true,
	docroot => $docroot,
	scriptalias => $scriptalias,
	serveradmin => $serveradmin,
	access_log_file => $ssl_access_log_file,
	priority => 15,
	ip => $ip,
	logroot_mode => $logroot_mode,
	manage_docroot => $default_ssl_vhost,
	use_servername_for_filenames => true,
	use_port_for_filenames => true,
	}

The request is a parameter to not manage them at all so the names are available.

I think manage_ is a more common pattern than create_.

[wywerne]

I think manage_ is a more common pattern than create_.

Ok for me, you are right