Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Ruby 3.3 support #9302

Open
bastelfreak opened this issue Mar 26, 2024 · 3 comments · May be fixed by #9303
Open

Implement Ruby 3.3 support #9302

bastelfreak opened this issue Mar 26, 2024 · 3 comments · May be fixed by #9303
Labels
enhancement New feature or request triaged Jira issue has been created for this

Comments

@bastelfreak
Copy link
Contributor

Use Case

Ruby 3.3 is available since some months. Some people build puppet against system Ruby and some distros already ship Ruby 3.3 or prepare it. As a Puppet user I would like to see support for current Ruby versions in latest Puppet

Describe the Solution You Would Like

Add Ruby 3.3 to CI.

Describe Alternatives You've Considered

Additional Context

This also correlates to puppetlabs/puppet-enterprise_issues#8
@bastelfreak bastelfreak added the enhancement New feature or request label Mar 26, 2024
bastelfreak added a commit to bastelfreak/puppet-1 that referenced this issue Mar 26, 2024
@bastelfreak
(puppetlabs#9302) Add Ruby 3.3 to CI matrix
8c8fa8f
@cthorn42 cthorn42 added the triaged Jira issue has been created for this label Mar 26, 2024
@github-actions GitHub Actions
Copy link

Migrated issue to PUP-12029

@cthorn42 cthorn42 linked a pull request Mar 26, 2024 that will close this issue
(#9302) Add Ruby 3.3 to CI matrix #9303
Open
@joshcooper
Copy link
Contributor

This is blocked on #9209

@ekohl
Copy link
Contributor

ekohl commented May 16, 2024

In Fedora https://bugzilla.redhat.com/show_bug.cgi?id=2280109 was reported, where Fedora 40 uses Puppet 8 and Ruby 3.3. The encoding parameter here changed in Ruby 3.3.

Quoting the BZ author:

For my environment, the "fix" was to edit puppet/functions/regsubst.rb#regsubst_string and simply remove the encoding argument to Regexp.compile, but that's obviously incorrect; a real patch here would probably do a switch on the encoding enum and either forcibly set the string encoding, or add Regexp::NOENCODING to re_flags in the 'N' case.

That's this line:

puppet/lib/puppet/functions/regsubst.rb

Line 91 in 779595a

inner_regsubst(target, Regexp.compile(pattern, re_flags, encoding), replacement, operation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triaged Jira issue has been created for this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#9302) Add Ruby 3.3 to CI matrix bastelfreak/puppet-1
4 participants
@ekohl @bastelfreak @joshcooper @cthorn42