Package type should support environment variables

[baurmatt]

I will just link to the JIRA ticket as this is now a (almost) 10 years old feature request which I'm just mirroring over to the new Github issue tracking process.

https://puppet.atlassian.net/browse/PUP-1526

[techsk8]

Been dying to see this one implemented for soo looong.

[joshcooper]

The original request was to support situations like:

# This is needed for removing the sudo package since it won't uninstall
# when there is no root password set or $SUDO_FORCE_REMOVE != yes
exec { '/usr/bin/apt-get --force-yes --assume-yes install sudo-ldap':
    environment => 'SUDO_FORCE_REMOVE=yes',
    unless      => '/usr/bin/dpkg -l sudo-ldap|tail -1|grep "^ii"'
}

An earlier attempt was made in #4928, but that was closed due to inactivity.

To add this capability, an environment parameter needs to be added to Puppet::Type::Package, similar to how this is done for Puppet::Type::Exec

puppet/lib/puppet/type/exec.rb

Line 300 in 57a00cc

newparam(:environment) do

If an environment parameter is specified on a package resource, then the package providers should pass the parameter into the Puppet::Util::Execution.execute method as a custom_environment

puppet/lib/puppet/util/execution.rb

Line 149 in 57a00cc

:custom_environment => {},

Similarly for calls to execpipe like

puppet/lib/puppet/provider/package/dpkg.rb

Line 24 in 57a00cc

Puppet::Util::Execution.execpipe(cmd, &block)

We also need to account for the has_command DSL method, which providers use to resolve commands like:

puppet/lib/puppet/provider/package/yum.rb

Line 25 in 57a00cc

commands :cmd => "yum", :rpm => "rpm"

I started hacking on this here https://github.com/puppetlabs/puppet/compare/main...joshcooper:puppet:package_environment?expand=1

[techsk8]

Do you estimate this will be released in the next minor puppet release?

[joshcooper]

Do you estimate this will be released in the next minor puppet release?

Sorry no, no idea. The branch above is just to explore different options and see how this might be implemented.