Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter scope passed in latest submissions method #1616

Closed
yash-learner opened this issue May 14, 2024 · 0 comments · Fixed by #1617
Closed

Fix filter scope passed in latest submissions method #1616

yash-learner opened this issue May 14, 2024 · 0 comments · Fixed by #1617
Assignees
Labels
bug Something isn't working

Comments

@yash-learner
Copy link
Member

Describe the bug
Wrong scope is passed in student_details_resolver and student_presenter latest_submissions method.

targets scope is passed instead of assignments

It was missed in update of scope in this #1605

To Reproduce
Steps to reproduce the behavior:

  1. Create a course with assignments
  2. Complete all the assignments
  3. Archive an assignment for a target - by selecting no for Does this target have an assignment?
  4. You should notice the miss match in percentage completed in student report - It shows more percentage for completion because of the timeline_events completed scope is getting course_targets instead of targets_with_assignments.

Expected behavior
Pass the correct scope

@yash-learner yash-learner added the bug Something isn't working label May 14, 2024
@yash-learner yash-learner self-assigned this May 14, 2024
@yash-learner yash-learner linked a pull request May 14, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant