Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many-to-Many relationship between Users and Organisations #1499

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Many-to-Many relationship between Users and Organisations #1499

wants to merge 10 commits into from

Conversation

kaisersakhi
Copy link
Member

Proposed Changes

@pupilfirst/developers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Check if route, query, or mutation authorization looks correct.
    • Add tests for authorization, if required.
  • Ensure that UI text is kept in I18n files.
  • Update developer and product docs, where applicable.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Check if new tables or columns that have been added need to be handled in the following services:
    • Users::DeleteAccountService
    • Courses::CloneService
    • Courses::DeleteService
    • Courses::DemoContentService
    • Levels::CloneService
    • Schools::DeleteService
  • Check if changes in packaged components have been published to npm.
  • Add development seeds for new tables.
  • If the updates involve Graph mutations ensure that the files are migrated to the new approach without a mutator.
  • If the updates involve adding a new table ensure that rate limiting is added and documented in the docs/developers/rate_limiting.md file.

@kaisersakhi kaisersakhi marked this pull request as draft November 24, 2023 09:40
@kaisersakhi
Minor changes
497fbc4
@kaisersakhi
Merge branch 'master' into issues/1473/many-to-many-relationship-betw…
a165aef 
…een-users-and-organisations
@kaisersakhi
Merge branch 'issues/1473/many-to-many-relationship-between-users-and…
cc7a25f 
…-organisations' of github.com:kaisersakhi/pupilfirst into issues/1473/many-to-many-relationship-between-users-and-organisations
@kaisersakhi
Merge branch 'master' into issues/1473/many-to-many-relationship-betw…
7e68480 
…een-users-and-organisations
@kaisersakhi
Merge branch 'master' into issues/1473/many-to-many-relationship-betw…
4dd61da 
…een-users-and-organisations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move the organisation_id from users to students table
1 participant
@kaisersakhi