Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to nextcloud? #183

Open
Emporea opened this issue Nov 11, 2022 · 5 comments
Open

Migrating to nextcloud? #183

Emporea opened this issue Nov 11, 2022 · 5 comments
Labels
meta Not a bug or feature

Comments

@Emporea
Copy link

Emporea commented Nov 11, 2022

Are there plans to migrate this repo to nextcloud / get the official label and maybe even replace the nextcloud photos at some point, because honestly memories is so much better since it uses metadata and is so much faster..

@pulsejet pulsejet added the meta Not a bug or feature label Nov 11, 2022
@pulsejet
Copy link
Owner

pulsejet commented Nov 11, 2022

See this comment: #183 (comment)

Are there plans to migrate this repo to nextcloud / get the official label

No. At least not as long as I'm the major contributor / maintainer, and not employed by Nextcloud (very unlikely). Also see #12

Perhaps a "Featured" label in the app store might be useful for discoverability. No idea what the requirements are though. Maybe someone can chip in.

@meichthys
Copy link
Contributor

@pulsejet I don't think there are any specified requirements currently. According to this, it's just an admin setting on the app store itself.

@pulsejet
Copy link
Owner

Well that's how you do it. Internally there may be other requirements, e.g. being maintained by a Nextcloud employee.

@luxzg
Copy link

luxzg commented Jul 4, 2023

I'd love some spotlight for Memories... Least I could do is add my comments, and open another issue in the First run wizard repo:

nextcloud/firstrunwizard#911

Edit: maybe some github crosslinking turns someone's eye to this eventually...

@pulsejet
Copy link
Owner

pulsejet commented Oct 26, 2023

Pinning this because it gets asked so often. I want to clarify the current position on this (from my side):

Will Memories replace Photos or merge into one app?

Short Answer:
No. Memories has a different target audience, and is meant to provide an alternative to Photos for users who want a better experience. It is not a fork of Photos, and will not be merged upstream.

Long Answer:

There are two distinct arguments why the separate apps makes sense.

  1. The target audience may be different. Photos is included with every installation of Nextcloud and is quite simple and works out-of-the-box, without adding any extra maintenance and database overhead. This situation may be ideal in some cases, e.g. if you're a university and storing photos isn't your primary use case. I can imagine such instances make a large portion of Nextcloud users since it is, after all, an enterprise productivity suite.
  2. Difference in architectural opinions. The way Memories and Photos work are completely different, and while I believe Memories has "better" design choices, this is not universal opinion. For instance (note that all of these are trade-offs; my presentation may come off as a bit biased):
    • Use of WebDAV: Photos exclusively uses WebDAV for all its operations while Memories uses a JSON REST API. While WebDAV brings some nice things like being able to use any compatible app to view your albums etc. I don't believe it is possible to optimize it enough (especially the way it is implemented) to have acceptable performance for the kind of queries needed here. Also WebDAV is an aging standard and uses XML, which is both slow to parse compared to JSON and much harder to make type-safe without runtime checks. WebDAV is also lexical, causing weird issues in unexpected places; this led to weird workarounds like putting the fileid in the "artificial" filename in recognize just to be able to differentiate files.
    • Querying methodology: Photos uses WebDAV for queries, which means all queries must be formed from the same basic building blocks that WebDAV provides. The up side is that this makes the implementation more modular and possibly easier to debug. But this makes it impossible (IMO) to do the complex DB queries that are for instance used by the Memories timeline. Instead, Photos performs most functions either in PHP or the frontend, which means the database can barely optimize anything.
    • Personally I think Photos suffers from an overgeneralization trap. Implementing everything (or most things) in the Nextcloud core sounds nice, but a photo gallery is finally an application providing specific functionality. Trying to implement everything in the core will both drag down the development of the app and potentially bloat the core with unnecessary things. This also creates a bunch of tradeoffs that need not exist to begin with if these functions stayed in the app, and makes the architecture even more monolithic and entangled.
    • There are others. But the idea is, each app makes design decisions that don't agree and there's no clear "right" way to make such an app.

Is there some middle ground?

One potential solution that I hope for is, Nextcloud can provide better visibility to Memories as an alternative to Photos. A large fraction of Nextcloud administrators are unaware of the existence of Memories or are (understandably) apprehensive of installing a third-party app. IMHO this just hurts Nextcloud's image for home users, evident by all the hate at r/selfhosted especially whenever Nextcloud gets mentioned for photo management. Regardless of the technical differences, I think I can say that Memories is leagues ahead of Photos in terms of engineering and optimization, besides the feature set itself.

As of now, I've seen a few posts from others mentioning something similar with no response from Nextcloud GmbH. I do understand this is somewhat of an uncomfortable topic though, since Memories may seem like a "competitor" to Photos which was developed by Nextcloud. As a result, I won't push this issue myself, but feel free to upvote any of the existing requests out there if you agree with me :)

Update 2023/11/19: updated a paragraph above.

If you've other thoughts, feel free to comment on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Not a bug or feature
Projects
None yet
Development

No branches or pull requests

4 participants