Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Consuming resources #185

Open
bamarni opened this issue Feb 23, 2016 · 1 comment
Open

[doc] Consuming resources #185

bamarni opened this issue Feb 23, 2016 · 1 comment

Comments

@bamarni
Copy link

bamarni commented Feb 23, 2016

Some content from this page is outdated (http://docs.puli.io/en/latest/discovery/consuming-resources.html), from what I could see :

  • findByType() is now findBindings()
  • resource discovery / binding are not part of the Api anymore but concrete implementations

Is the Api stable enough to update the docs? If you can provide some guidelines I can try to submit a PR.

Also :

  • what would be the equivalent of findByPath()?
  • should there be checks for instance of ResourceBinding in the loops?
@webmozart
Copy link
Member

Thanks for reporting this issue! The API should be stable enough once the next release is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants