Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no consistency in using single/double precision #395

Open
Tracked by #438
daurer opened this issue Mar 29, 2022 · 1 comment
Open
Tracked by #438

no consistency in using single/double precision #395

daurer opened this issue Mar 29, 2022 · 1 comment
Labels
child issue This issue should be addressed in a larger rework/context

Comments

@daurer
Copy link
Contributor

daurer commented Mar 29, 2022

I noticed that in many places (e.g. get_data_chunk in ptypy/core/data.py) we are casting data to double precision no matter what precision has been set by the user. This often happens when there is a np.array(...) conversion. We should probably make sure that we are consistently use either single or double precision.
@bjoernenders bjoernenders added the child issue This issue should be addressed in a larger rework/context label Jan 17, 2023
@bjoernenders
Copy link
Contributor

Should be part of the review of the PtyScan class #438

@bjoernenders bjoernenders mentioned this issue Jan 17, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
child issue This issue should be addressed in a larger rework/context
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daurer @bjoernenders