Parameter validation error in 3d branch after recent commits

[susannahammarberg]

Hey!

I have problems running reconstructions in the 3d branch after recent commits. Ptypy complains about me not stating a name for the PtyScan subclass in my initialization script (but I do..).
In my script I have something like:

p.scans = u.Param()
p.scans.scan01 = u.Param()
p.scans.scan01.name = 'Bragg3dModel'
p.scans.scan01.data= u.Param()
p.scans.scan01.data.name = 'Bragg3dSimScan'

and I get the error: "Parameter validation failed:
scans.scan01.data - make sure to specify the .name field"

(and if I go back to the commit I used previously, there was a problem with the ptyr-files being empty, so I dont know which commit to go back to).

Thanks in advance for advice!
Sanna

[pierrethibault]

Hi Sanna,

I think that this behaviour has been introduced recently in an attempt to avoid all ptyscan subclasses to be imported because it reality only one at a time is needed. Can you try to add the specific import at the top of your script?

from ptypy.experiment import Bragg3dSim

This should load your ptyscan class.

Pierre

[susannahammarberg]

Yes, that worked! Thank you.

Sanna

[alexbjorling]

We should produce some more reasonable error message here.

[pierrethibault]

I suggest that we manage this through custom exception classes (i.e. MissingParameterError, UnknownParameterError, TypeParameterError). We should consider doing this throughout ptypy...

[aaron-parsons]

I'm bumping this to the 0.4 release, since the 0.3 is basically done now. If it get's too annoying then a patch would be fine to do.

[bjoernenders]

Needs to be reviewed if there is still a bug. Looks like it belongs to the Param evualation. #449