fix gap detection #244
Closed
fix gap detection #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves #243
codeliner
requested changes
Oct 22, 2022
| $sleep = $this->gapDetection->getSleepForNextRetry(); | ||
|
|
||
| \usleep($sleep); | ||
| \usleep($this->gapDetection->getSleepForNextRetry() * 1000); |
There was a problem hiding this comment.
I'm thinking about whether we should do the calculation or change the documentation and tell people that sleep time is configured in microseconds 🤔
When multiplying sleep time 1 ms is the shortest sleep interval possible. Maybe that's too long for some use cases?
There was a problem hiding this comment.
The good thing is, changing documentation wouldn't change the current behavior. Gap detection is used in production systems, so people have already identified the best sleep time settings for their projections.
There was a problem hiding this comment.
I'm with @codeliner here - afaik this is a BC (as unfortunate it may be).
|
Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #243
/cc @hvanoch