Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus.DiagnosticSourceAdapter missing in .NET Framework build #474

Open
hickford opened this issue Apr 11, 2024 · 2 comments · May be fixed by #475
Open

Prometheus.DiagnosticSourceAdapter missing in .NET Framework build #474

hickford opened this issue Apr 11, 2024 · 2 comments · May be fixed by #475

Comments

@hickford
Copy link

hickford commented Apr 11, 2024 •
edited

I'd like to use Prometheus.DiagnosticSourceAdapter but it's missing in the .NET Framework build

It appears to be compiled only on .NET https://github.com/prometheus-net/prometheus-net/blob/master/Prometheus/DiagnosticSourceAdapter.cs

What's the reason for this? It would be good to explain at https://github.com/prometheus-net/prometheus-net/blob/master/README.md#diagnosticsource-integration
@hickford hickford changed the title DiagnosticSourceAdapter missing in .NET Framework Prometheus.DiagnosticSourceAdapter missing in .NET Framework build Apr 11, 2024
@hickford
Copy link
Author

Use case: my .NET Framework app has System.Diagnostics.Metrics . I'm using NuGet package https://www.nuget.org/packages/System.Diagnostics.DiagnosticSource/

@hickford hickford linked a pull request Apr 11, 2024 that will close this issue
Draft
@ibauersachs
Copy link

The holds for the MeterAdapter: that would also work on .NET Framework by referencing the NuGet package Microsoft.Extensions.Diagnostics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compile DiagnosticSourceAdapter on .NET Framework hickford/prometheus-net
2 participants
@hickford @ibauersachs