Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for changing the default NewExemplarMinInterval #467

Open
mrmartan opened this issue Jan 8, 2024 · 0 comments
Open

Allow for changing the default NewExemplarMinInterval #467

mrmartan opened this issue Jan 8, 2024 · 0 comments

Comments

@mrmartan
Copy link

mrmartan commented Jan 8, 2024

...without having to replace the entire default exemplar behavoir. Currently I have to take dependency on the ExemplarBehavior..ctor and while now there are only two properties that might change and I don't think this is a good design.

Current:

Metrics.DefaultFactory.ExemplarBehavior = new ExemplarBehavior
{
    DefaultExemplarProvider = (_, _) => Exemplar.FromTraceContext(),
    NewExemplarMinInterval = TimeSpan.FromMinutes(1)
};

Expected (or something like):

Metrics.DefaultFactory.DefaultExemplarBehavior.NewExemplarMinInterval = TimeSpan.FromMinutes(1);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant