Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical dependency: the request of a dependency is an expression #7

Open
haddigan opened this issue Jun 29, 2017 · 0 comments
Open

Comments

@haddigan
Copy link

I'm importing into a create-react-app project and I'm getting a few warnings from webpack/ajv:

./~/ajv/lib/compile/index.js 13:21-34 Critical dependency: the request of a dependency is an expression
./~/ajv/lib/async.js 96:20-33 Critical dependency: the request of a dependency is an expression
./~/ajv/lib/async.js 119:15-28 Critical dependency: the request of a dependency is an expression

which apparently has to do with this webpack issue and dynamic requires.

According to this comment it can cause every file below a certain path to be included in the bundle, which seems to be the case here. My build with html-to-json weighs in at 1554 KB but without it builds to 229KB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant