Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support getting LoadBalancerStatus from an Ingress (e.g. AWS ALB) or Gateway #4952

Open
kahirokunn opened this issue Dec 31, 2022 · 21 comments · May be fixed by #5987
Open

support getting LoadBalancerStatus from an Ingress (e.g. AWS ALB) or Gateway #4952

kahirokunn opened this issue Dec 31, 2022 · 21 comments · May be fixed by #5987
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
1.30.0

Comments

@kahirokunn
Copy link

I am using Ingress + NodePortS without LoadBalancerService.
Therefore, it is useful to have envoy-ingress-name and envoy-ingress-namespace.
Similarly, it may be useful to have envoy-gateway-name and envoy-gateway-namespace as well, since the Gateway API is expected to become more active in the future.

related Issues: #4951
@kahirokunn kahirokunn added kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Dec 31, 2022
@sunjayBhatia
Copy link
Member

the envoy-service-name/namespace flags are used for identifying which LoadBalancer Service External IP to watch in order to populate the LoadBalancer IP on Ingress/HTTPProxy resources. I'm not sure how that fits in with the proposed flags you mention here?

@kahirokunn
Copy link
Author

LoadBalancer Service External IP to watch in order to populate the LoadBalancer IP on Ingress/HTTPProxy resources.

@sunjayBhatia I also think that flags will be needed to identify which external IP of the Ingress (eg. aws-load-balancer-controller) to monitor.

@sunjayBhatia
Copy link
Member

I'm not sure what you mean by that, can you clarify a bit? How is your ALB set up to interact with Contour and what information on which resources are you missing?

@kahirokunn
Copy link
Author

@sunjayBhatia Sorry for the lack of explanation.

  1. LoadBalancer Service -> envoy is the default configuration
  2. Ingress (ingressClass alb) -> NodePort Service -> envoy is the configuration I use

The reason I use ALB (Ingress + NodePort Service) instead of NLB (LoadBalancer Service) is to use AWS WAF.
https://aws.amazon.com/waf/?nc1=h_ls

Many companies have places where they would like to use AWS WAF.
However, in that case, contour cannot configure the HTTPProxy status.loadbalancer.
If status.loadbalancer is not set, External DNS, etc. will not work, and it will be difficult to find out to which ingress (ALB) it is connected.

@sunjayBhatia
Copy link
Member

Thanks for spelling that out, makes sense

We have not put too much work into Contour's UX when using an ALB setup so we'll have to think a little about how we want to have this work

@kahirokunn
Copy link
Author

I see.
Contour is the best product out there, so I'd be very happy if you'd consider the ALB experience as well!
Thx!!!

@kahirokunn
Copy link
Author

@sunjayBhatia @skriss
I want to make contour easy to use in ALB as well.
If I write golang code to add envoy-ingress-name and envoy-ingress-namespace and create a PR, can you merge it?
The intent of my question is to make sure that if I create this feature and it does not get merged, it will be a wasted effort.

kahirokunn added a commit to kahirokunn/contour that referenced this issue Feb 13, 2023
@kahirokunn
Add --envoy-ingress-name, and --envoy-ingress-namespace flags. (p…
40f9cc5 
…rojectcontour#4952)

Signed-off-by: CRA Kahiro Okina <kahiro.okina@craftsman-software.com>
@kahirokunn kahirokunn mentioned this issue Feb 13, 2023
Closed
kahirokunn added a commit to kahirokunn/contour that referenced this issue Feb 13, 2023
@kahirokunn
Add --envoy-ingress-name, and --envoy-ingress-namespace flags. (p…
6122063 
…rojectcontour#4952)

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 28, 2023
@kahirokunn
Copy link
Author

keep

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 29, 2023
@skriss skriss changed the title We have envoy-service-name and envoy-service-namespace, but we would like to have envoy-ingress-name and envoy-ingress-namespace, envoy-gateway-name and envoy-gateway-namespace and so on. support getting LoadBalancerStatus from an Ingress (e.g. AWS ALB) Apr 6, 2023
@skriss skriss removed the lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. label Apr 6, 2023
@skriss skriss changed the title support getting LoadBalancerStatus from an Ingress (e.g. AWS ALB) support getting LoadBalancerStatus from an Ingress (e.g. AWS ALB) or Gateway Apr 6, 2023
@skriss
Copy link
Member

skriss commented Apr 6, 2023

xref #2539, has some additional use cases around sourcing the LoadBalancerStatus

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 6, 2023
@kahirokunn
Copy link
Author

keep

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2023
@kahirokunn
Copy link
Author

Keep

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 8, 2023
@kahirokunn
Copy link
Author

Keep

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2023
hligit pushed a commit to hligit/contour that referenced this issue Nov 24, 2023
@kahirokunn @hligit
Add --envoy-ingress-name, and --envoy-ingress-namespace flags. (p…
70e9be9 
…rojectcontour#4952)

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@hligit hligit linked a pull request Nov 25, 2023 that will close this issue
Open
hligit pushed a commit to hligit/contour that referenced this issue Dec 5, 2023
@kahirokunn @hligit
Add --envoy-ingress-name, and --envoy-ingress-namespace flags. (p…
8f33988 
…rojectcontour#4952)

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
hligit pushed a commit to hligit/contour that referenced this issue Dec 5, 2023
@kahirokunn @hligit
Add --envoy-ingress-name, and --envoy-ingress-namespace flags. (p…
7380ee8 
…rojectcontour#4952)

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
hligit pushed a commit to hligit/contour that referenced this issue Dec 5, 2023
@kahirokunn @hligit
Add --envoy-ingress-name, and --envoy-ingress-namespace flags. (p…
00c2ae2 
…rojectcontour#4952)

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 11, 2023
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2024
@kahirokunn
Copy link
Author

keep

@kahirokunn
Copy link
Author

/reopen

@tsaarni tsaarni removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 16, 2024
@tsaarni tsaarni reopened this Jan 16, 2024
@skriss
Copy link
Member

skriss commented Jan 16, 2024

@hligit is working on this

@skriss skriss added this to the 1.29.0 milestone Jan 16, 2024
@skriss skriss modified the milestones: 1.29.0, 1.30.0 May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Contour
Status: In Progress
Milestone
1.30.0
Development

Successfully merging a pull request may close this issue.

Inspect loadbalancer address from Envoy ingress objects hligit/contour
4 participants
@tsaarni @skriss @sunjayBhatia @kahirokunn