Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add region ID support for IVSHMEM Devices #8566

Open
yonghuah opened this issue Mar 17, 2024 · 1 comment
Open

Add region ID support for IVSHMEM Devices #8566

yonghuah opened this issue Mar 17, 2024 · 1 comment

Comments

@yonghuah
Copy link
Contributor

  1. Use “Subsystem ID” in PCI configuration space to indicate Link ID of IVSHMEM devices
  2. “Subsystem Vendor ID” will be hardcoded to “0x8086”
  3. Format to define IVSHMEM regions will be revised:

Link ID is required when configuring IVHSMEM instance:
Applicable to both DM-land and HV-land IVSHMEM devices.
4. Impacted components: ACRN Hypervisor/ Device Model and ACRN config tool.
@yonghuah
Copy link
Contributor Author

[External_System_ID] ACRN-10265

yonghuah added a commit to yonghuah/acrn-hypervisor that referenced this issue Mar 17, 2024
@yonghuah
config_tools: support IVSHMEM devices region ID configuration
7fca01c 
   This patch adds ivshmem region ID configuration support when user
   configure ACRN IVSHMEM devices via ACRN config tool, this ID provides
   VMs with a stable identification of multiple shared memory regions.

   Also add logic to generate launch script with region ID configured
   as below:
   `add_virtual_device  8 ivshmem hv:/shm_region_0,256,1`

Tracked-On: projectacrn#8566
Signed-off-by: Kunhui-Li <kunhuix.li@intel.com>
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
yonghuah added a commit to yonghuah/acrn-hypervisor that referenced this issue Mar 17, 2024
@yonghuah
hv: fill region ID to hv-land ivshmem PCI config space
3f5d88b 
   1) region ID shall be configured by user via config tool.
   2) region ID is programmed to "Subsystem ID" of PCI config space.
   2) "Subsystem Vendor ID" is harded coded as 0x8086

Tracked-On: projectacrn#8566
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
yonghuah added a commit to yonghuah/acrn-hypervisor that referenced this issue Mar 17, 2024
@yonghuah
dm: fill region ID to dm-land ivshmem PCI config space
cfbdbed 
  1) region ID shall be configured by user via config tool.
  2) region ID is programmed to "Subsystem ID" of PCI config space.
  2) "Subsystem Vendor ID" is harded coded as 0x8086

  Parameters to configure dm-land IVSHMEM device example generated
  by config tool as below:
  `add_virtual_device   8 ivshmem hv:/shm_region_0,256,2`

Tracked-On: projectacrn#8566
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Jian Jun Chen <jian.jun.chen@intel.com>
acrnsi-robot pushed a commit that referenced this issue Mar 28, 2024
@yonghuah @acrnsi-robot
config_tools: support IVSHMEM devices region ID configuration
a7a6732 
   This patch adds ivshmem region ID configuration support when user
   configure ACRN IVSHMEM devices via ACRN config tool, this ID provides
   VMs with a stable identification of multiple shared memory regions.

   Also add logic to generate launch script with region ID configured
   as below:
   `add_virtual_device  8 ivshmem hv:/shm_region_0,256,1`

Tracked-On: #8566
Signed-off-by: Kunhui-Li <kunhuix.li@intel.com>
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
acrnsi-robot pushed a commit that referenced this issue Mar 28, 2024
@yonghuah @acrnsi-robot
hv: fill region ID to hv-land ivshmem PCI config space
ddfe218 
   1) region ID shall be configured by user via config tool.
   2) region ID is programmed to "Subsystem ID" of PCI config space.
   2) "Subsystem Vendor ID" is harded coded as 0x8086

Tracked-On: #8566
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
acrnsi-robot pushed a commit that referenced this issue Mar 28, 2024
@yonghuah @acrnsi-robot
dm: fill region ID to dm-land ivshmem PCI config space
9325664 
  1) region ID shall be configured by user via config tool.
  2) region ID is programmed to "Subsystem ID" of PCI config space.
  2) "Subsystem Vendor ID" is harded coded as 0x8086

  Parameters to configure dm-land IVSHMEM device example generated
  by config tool as below:
  `add_virtual_device   8 ivshmem hv:/shm_region_0,256,2`

Tracked-On: #8566
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Jian Jun Chen <jian.jun.chen@intel.com>
yonghuah added a commit to yonghuah/acrn-hypervisor that referenced this issue Apr 10, 2024
@yonghuah
hv: fix potential NULL pointer dereferrence in ivshmem.c
9a5ae20 
secure coding fix.

Tracked-On: projectacrn#8566
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
@yonghuah yonghuah mentioned this issue Apr 10, 2024
Merged
acrnsi-robot pushed a commit that referenced this issue Apr 10, 2024
@yonghuah @acrnsi-robot
hv: fix potential NULL pointer dereferrence in ivshmem.c
d5d21fd 
secure coding fix.

Tracked-On: #8566
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yonghuah