Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling optional clusters results in a 🟥 error #1267

Open
andy31415 opened this issue Feb 21, 2024 · 1 comment
Open

Disabling optional clusters results in a 🟥 error #1267

andy31415 opened this issue Feb 21, 2024 · 1 comment
Assignees
Labels
matter Important to Matter SDK

Comments

@andy31415
Copy link
Contributor

For example RootNodes can optionally have Unit Localization cluster enabled. ZAP currently complains about Unit localization server needs to be enabled. However this is wrong: for practical purposes this is an optional cluster that happens to be enabled by default by zap (if you have some UI you need this)

Showing such errors generally would train users to ignore red siren warnings as "normal".

instead, we should either not show any warning (this is optional after all) or show information-level notices about this that "a default was changed" (and no red sirens for this - maybe some note/info icons at most).

@andy31415
Copy link
Contributor Author

Specifical example from the spec: all hightlighted items may or may not be set:

image

@brdandu brdandu added the matter Important to Matter SDK label Feb 22, 2024
@brdandu brdandu self-assigned this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
matter Important to Matter SDK
Development

No branches or pull requests

2 participants