Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Energy management built in types to ZAP tool #1219

Open
jamesharrow opened this issue Nov 29, 2023 · 2 comments · May be fixed by #1220
Open

Add Energy management built in types to ZAP tool #1219

jamesharrow opened this issue Nov 29, 2023 · 2 comments · May be fixed by #1220

Comments

@jamesharrow
Copy link

As part of Spring 2024 we are targetting new Energy Management clusters which have introduce 4 new types (like epoch_s):

This spec PR has added new changes to Data-Model.adoc:
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7830/files#diff-05653d18812836190adf870ff988791e0e3901478a63ab1eca4c3e9df0168a8c

                 | Power                       s| <<ref_DataTypePower, power-mW>>          | int64     | 0xD9 | 8 bytes
                 | Amperage                    s| <<ref_DataTypeAmperage, amperage-mA>>    | int64     | 0xDA | 8 bytes
                 | Voltage                     s| <<ref_DataTypeVoltage, voltage-mW>>      | int64     | 0xDB | 8 bytes
                 | Energy                      s| <<ref_DataTypeEnergy, energy-mWh>>       | int64     | 0xDC | 8 bytes

[[ref_DataTypePower, Power]]
==== Power
This type, derived from int64, represents power measured in milliwatts.

[[ref_DataTypeAmperage, Amperage]]
==== Amperage
This type, derived from int64, represents amperage measured in milliamps.

[[ref_DataTypeVoltage, Voltage]]
==== Voltage
This type, derived from int64, represents voltage measured in millivolts.

[[ref_DataTypeEnergy, Energy]]
==== Energy
This type, derived from int64, represents energy measured in milliwatt-hours.

<type id="0xE4" description="Epoch Seconds" name="epoch_s" size="4" analog="true" />

These need to be added to ZAP tool to unblock chip repo Issues:
project-chip/connectedhomeip#30665

and it's PR: project-chip/connectedhomeip#30701

@jamesharrow
Copy link
Author

I may withdraw this issue - since it looks like the logic is in chip repo and possibly not needed here...

@brdandu
Copy link
Collaborator

brdandu commented May 20, 2024

@jamesharrow this requires a xml change in the Matter GSDK. What we have in ZAP is just default meta data which allows zap to be tested. Actually xml/json meta data should be retrieved from the GSDKs. Are there any other concerns here or is it ok to close this issue here?

@brdandu brdandu self-assigned this May 20, 2024
@brdandu brdandu moved this from To Do to In Progress in Silicon Labs - internal work May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants