Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] ColorControl Specs miss allowing RemainingTime alue 0xFFFF for "looping colors" vs chip implementation #33325

Open
Apollon77 opened this issue May 7, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation needs triage spec Mismatch between spec and implementation

Comments

@Apollon77
Copy link
Contributor

Apollon77 commented May 7, 2024

Documentation issues

The ColorControl cluster specification for the Attribute "RemainingTime" defines the value raneg as 0..65534.

The chip tool implementation uses value MAX_INT16U_VALUE (from my knowledge a define for 0xFFFF) in the cases where a color loop is "endless". Setting this value as Remaining time is e.g. done in

Attributes::RemainingTime::Set(endpoint, MAX_INT16U_VALUE);
(and other places).
This value is against the specs.

Additionally, the specification do not contain any information about "How Remaining Time should be set when the loop is endless", so this should also be added too.

Platform

core (please add to version below)

Anything else?

No response

@Apollon77 Apollon77 added documentation Improvements or additions to documentation needs triage labels May 7, 2024
@woody-apple woody-apple added the spec Mismatch between spec and implementation label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation needs triage spec Mismatch between spec and implementation
Projects
Development

No branches or pull requests

2 participants