Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [Python] Drop ChipStack network lock #33321

Open
agners opened this issue May 6, 2024 · 0 comments
Open

[Feature] [Python] Drop ChipStack network lock #33321

agners opened this issue May 6, 2024 · 0 comments

Comments

@agners
Copy link
Contributor

agners commented May 6, 2024

Feature description

Currently several places which call PostTaskOnChipThread take a networkLock in the ChipStack class. It is not clear what this lock exactly protects. From the the function ultimately calls ScheduleWork from src/include/platform/PlatformManager.h, which should be safe to be called from any Thread:

 * ScheduleWork can be called safely on any thread without locking the
* stack.  When called from a thread that is not doing the stack work item
* processing, the callback function may be called (on the work item
* processing thread) before ScheduleWork returns.

Platform

python

Platform Version(s)

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant