New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] [inet] TestInetLayer is not currently run, next steps to be figured out #33313

Open

Alami-Amine opened this issue May 6, 2024 · 1 comment

Assignees

Labels

CI/CD improvements

Contributor

Alami-Amine commented May 6, 2024 •

edited

Issue Description

TestInetLayer.cpp is not currently run. We need to figure out what to do with it.
it looks like it should be an executable, but no apparent usage of it is found; it is unclear when it was last executed.
It is currently compiled into a static library called "libInetTestHelpers" along with a bunch of other support files.

Next Actions

investigate the test: read the code and compile it to see what it does.
What to do with it: Should the test be converted to a unit test or should it be deleted.

Alami-Amine added the CI/CD improvements label

Alami-Amine self-assigned this

Contributor Author

Alami-Amine commented May 6, 2024 •

edited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment