Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2462 #3239

Merged
merged 5 commits into from Apr 24, 2024
Merged

Issue 2462 #3239

merged 5 commits into from Apr 24, 2024

Conversation

charlottejmc
Copy link
Contributor

@charlottejmc charlottejmc commented Apr 5, 2024

I have implemented the changes suggested by a very helpful external contributor (Leonardo Barleta) to adjust the steps under the ### On Windows section.

Closes #2462

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Manager @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Implement changes suggested by Leonardo (external contributor)
Typesetting changes
Add lesson-tester to YAML
@charlottejmc
Copy link
Contributor Author

Dear @jenniferisasi and @ericbrasiln,

We've received a very helpful contribution from an external contributor, who's updated the ## On Windows section (and two extra lines) to fix the problems raised in the Lesson Maintenance issue #2462.

I would be very grateful if you could coordinate a translation of these changes in Spanish and Portuguese!

Please only refer to the changes you can see in the 'rich diff' from this commit, as I made some subsequent typesetting changes which you don't need to worry about. (I can implement those later myself, after your translation.)

Thank you very much for your time.

@anisa-hawes
Copy link
Contributor

anisa-hawes commented Apr 5, 2024

Thank you for preparing this for us, @charlottejmc!


Grateful thanks to Leonardo Barleta @lbarleta for contributing ! ✨

@anisa-hawes anisa-hawes mentioned this pull request Apr 19, 2024
7 tasks
@ericbrasiln
Copy link
Member

Hello @charlottejmc

This lesson hasn't been published in Portuguese yet, and the translation process is currently on hold.

I'll add a comment to the translation issue to highlight the need for these changes to be incorporated.

Copy link
Member

@ericbrasiln ericbrasiln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@charlottejmc
Copy link
Contributor Author

Hi @ericbrasiln, apologies for the confusion!

Thank you very much for linking this PR in the issue thread for the ongoing PT translation.

@charlottejmc charlottejmc merged commit 7fa6067 into gh-pages Apr 24, 2024
5 checks passed
@charlottejmc charlottejmc deleted the Issue-2462 branch April 24, 2024 11:46
@charlottejmc charlottejmc restored the Issue-2462 branch April 24, 2024 11:48
@charlottejmc charlottejmc deleted the Issue-2462 branch April 24, 2024 11:52
@charlottejmc charlottejmc restored the Issue-2462 branch April 24, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User reported Issue: Building a static website with Jekyll (on Windows)
3 participants