Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ktor for the underlying HTTP request handler #175

Open
EdricChan03 opened this issue Mar 26, 2024 · 0 comments
Open

Use Ktor for the underlying HTTP request handler #175

EdricChan03 opened this issue Mar 26, 2024 · 0 comments

Comments

@EdricChan03
Copy link

Is your feature request related to a problem? Please describe.

Currently, we need to specify platform-specific options like OkHttpClient and NSURLSession for Android and iOS respectively.

Describe the solution you'd like

Using Ktor would help remove the tight coupling to a specific HTTP client implementation, and also allows for consumers who have already been using it to easily adopt this parser library. Additionally, it's also officially recommended as the Kotlin Multiplatform HTTP client/server to use.

Describe alternatives you've considered

We could use interfaces and/or expect/actual as expected from Kotlin Multiplatform modules.

Additional context

I was looking at the README when I noticed that there were platform-specific instructions for Android and iOS to specify their platform-specific OkHttpClient/NSURLSession for the underlying HTTP client to use when parsing the data.

Hopefully I'm not missing any additional information, but I also did a quick cursory search for "ktor" in the codebase/GitHub issues and found no results. I suspect these requirements were from before the library was converted to a Kotlin Multiplatform project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant