Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[General] Update cached seasons #97

Open
probberechts opened this issue Nov 11, 2022 · 0 comments
Open

[General] Update cached seasons #97

probberechts opened this issue Nov 11, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@probberechts
Copy link
Owner

probberechts commented Nov 11, 2022 •
edited

The scrapers cache the result of read_seasons(). Therefore, users might get a KeyError: ['<season>'] not in index if they forget to empty the cache when new seasons become available. A proper exception should be raised in such a case with a hint to empty the cache.
@probberechts probberechts added the enhancement New feature or request label Nov 25, 2022
@probberechts probberechts changed the title [WhoScored] Update cached seasons [General] Update cached seasons Jan 8, 2023
@probberechts probberechts mentioned this issue Aug 21, 2023
Closed
@probberechts probberechts mentioned this issue Aug 29, 2023
Closed
@probberechts probberechts mentioned this issue Sep 27, 2023
Closed
Kalaweksh added a commit to Kalaweksh/soccerdata that referenced this issue Apr 6, 2024
@Kalaweksh
[FBref] Add force_cache param to read_team_match_stats
62b7d8a 
- Reduce unnecessary scraping by attempting to read previous seasons from cache. Like probberechts#97 , this can be problematic at season start (in this case if a previous season hasn't been fully cached).

- Keep consistency with other FBref methods
@Kalaweksh Kalaweksh mentioned this issue Apr 6, 2024
Merged
probberechts pushed a commit that referenced this issue Apr 12, 2024
@Kalaweksh @probberechts
[FBref] Add force_cache param to read_team_match_stats
1586daa 
- Reduce unnecessary scraping by attempting to read previous seasons from cache. Like #97 , this can be problematic at season start (in this case if a previous season hasn't been fully cached).

- Keep consistency with other FBref methods
@probberechts probberechts mentioned this issue Apr 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@probberechts