Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WhoScored] Broken read_schedule() method #581

Closed
probberechts opened this issue May 14, 2024 · 5 comments · Fixed by #582
Closed

[WhoScored] Broken read_schedule() method #581

probberechts opened this issue May 14, 2024 · 5 comments · Fixed by #582
Assignees
Labels
bug Something isn't working WhoScored Issue or pull request related to the WhoScored scraper

Comments

@probberechts
Copy link
Owner

WhoScored has updated the HTML structure of their fixture pages. The scraper must be updated accordingly.

@probberechts probberechts added bug Something isn't working WhoScored Issue or pull request related to the WhoScored scraper labels May 14, 2024
@probberechts probberechts self-assigned this May 14, 2024
probberechts added a commit that referenced this issue May 15, 2024
WhoScored has updated the HTML structure of their fixture pages.

Fixes #581
@ds-oliver
Copy link

Hey - are we getting WS scraper back up?

@probberechts
Copy link
Owner Author

I am working on it. You can already use the version in the fix/whoscored-schedule branch. I need to do a bit more testing before releasing it.

@ds-oliver
Copy link

I am working on it. You can already use the version in the fix/whoscored-schedule branch. I need to do a bit more testing before releasing it.

I'll check that out. Cheers.

@ds-oliver
Copy link

I am working on it. You can already use the version in the fix/whoscored-schedule branch. I need to do a bit more testing before releasing it.

I tried to follow your advice with this and have encountered an issue while trying to check out and install the fix/whoscored-schedule branch. Here are the steps I followed and the errors I encountered:

  1. Cloned the repository:

    git clone https://github.com/probberechts/soccerdata.git soccerdata_whoscored_schedule
    cd soccerdata_whoscored_schedule
  2. Checked out the specific branch:

    git fetch --all
    git checkout fix/whoscored-schedule
  3. Created and activated a virtual environment:

    python -m venv venv
    source venv/bin/activate
  4. Upgraded pip, setuptools, and wheel:

    pip install --upgrade pip setuptools wheel
  5. Attempted to install the package in editable mode:

    pip install -e .

Despite these steps, I received the following error:

ERROR: Can not execute `setup.py` since setuptools is not available in the build environment.

I also tried creating a pyproject.toml file with the following content, but the issue persisted:

[build-system]
requires = ["setuptools", "wheel"]
build-backend = "setuptools.build_meta"

Additionally, I attempted to bypass the isolated build environment:

pip install --no-build-isolation -e .

However, the error still persists. Could you please provide guidance on how to resolve this issue? Is there a known problem with the setup.py or any dependencies in this branch that I should be aware of?

@probberechts
Copy link
Owner Author

Simply running the following works for me:

pip install git+https://github.com/probberechts/soccerdata.git@fix/whoscored-schedule

You could also try to install it using poetry.

probberechts added a commit that referenced this issue May 27, 2024
WhoScored has updated the HTML structure of their fixture pages.

Fixes #581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working WhoScored Issue or pull request related to the WhoScored scraper
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants