Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate PEP 563 impact on library #240

Open
prkumar opened this issue Dec 30, 2021 · 2 comments
Open

Investigate PEP 563 impact on library #240

prkumar opened this issue Dec 30, 2021 · 2 comments

Comments

@prkumar
Copy link
Owner

prkumar commented Dec 30, 2021

In Python 3.11, PEP 563 (postponed evaluation of annotations) will become the default. We need to investigate how the library's use of annotations will be impacted by this change.
@prkumar
Copy link
Owner Author

prkumar commented Dec 30, 2021

PEP 563 was originally planned to be turned on by default in Python 3.10, but was postponed to 3.11: https://mail.python.org/archives/list/python-dev@python.org/thread/CLVXXPQ2T2LQ5MP2Y53VVQFCXYWQJHKZ/

@fdemmer
Copy link

fdemmer commented Jan 21, 2023

This has become an minor annoyance for me today, as pyflakes complains about my Field("foo") annotations for @json having "F821 undefined name 'foo'".

I marked the lines with # noqa: F821 for now. Is there a better solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fdemmer @prkumar