Skeleton [size] property is no longer a string accepting rem values but instead expects shapes

[LightBulbIdea]

Describe the bug

Skeleton [size] property is no longer a string accepting REM values. It now requires the developer to pass either 'circle', 'square' or undefined. This change appears to be a mistake since there's already a shape property in said component. Because of this new change we can no longer specify the size of the skeleton.

This changed was introduced on v17.16.1

v17.16.0 file:

primeng/src/app/components/skeleton/skeleton.ts

Line 47 in 9df3367

@Input() size: string | undefined;

v.17.16.1 file: (This looks wrong)

primeng/src/app/components/skeleton/skeleton.ts

Line 47 in 7fdceab

@Input() size: 'circle' | 'square' | undefined;

Environment

Angular 17.3.4

PrimeNG 17.16.1

Reproducer

No response

Angular version

17.3.4

PrimeNG version

17.16.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

No response

Steps to reproduce the behavior

Code change to the skeleton's size property that seems unintentional.

Expected behavior

To be able to pass a size value rather than to be forced to pass in a shape since we already have a dedicated shape property.

[imaksp]

Hi, yes it looks like a mistake, introduced with this recent commit by @cetincakiroglu :
a521b10

[cetincakiroglu]

Hi,

Thanks for letting us know, we'll address it with the upcoming release.

[cetincakiroglu]

Fixed in #15540