Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: Fix broken unit test #15526

Closed
RogueTea opened this issue May 10, 2024 · 0 comments · Fixed by #15527
Closed

Dialog: Fix broken unit test #15526

RogueTea opened this issue May 10, 2024 · 0 comments · Fixed by #15527
Labels
Component: Test Issue or pull request is related to Component Testing Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.17.0

Comments

@RogueTea
Copy link
Contributor

Describe the bug

n this Discussion . I will also look into some broken tests and where needed extend test coverage.

This issue is not a bug ticket, but simply an issue for the PR to reference.

Environment

Windows

Reproducer

No response

Angular version

17.3.6

PrimeNG version

17.16.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v21.7.3

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@RogueTea RogueTea added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 10, 2024
@RogueTea RogueTea mentioned this issue May 10, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.16.2 milestone May 14, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 14, 2024
@cetincakiroglu cetincakiroglu added the Component: Test Issue or pull request is related to Component Testing label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Test Issue or pull request is related to Component Testing Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.17.0
Development

Successfully merging a pull request may close this issue.

Dialog: Fix broken unit test RogueTea/primeng
2 participants
@RogueTea @cetincakiroglu