Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site title in proposal wizard to include current proposal name #1761

Open
rixx opened this issue May 2, 2024 · 3 comments
Open

Update site title in proposal wizard to include current proposal name #1761

rixx opened this issue May 2, 2024 · 3 comments
Labels
good first issue A default GitHub label inviting first time contributors help wanted A default GitHub label inviting outside help javascript Pull requests that update Javascript code python Pull requests that update Python code size: small Easy and/or quick to do stage: up for grabs type: feature type: ux

Comments

@rixx
Copy link
Member

rixx commented May 2, 2024

This would make it much easier to work on multiple proposals in different tabs at the same time.

We could even update the title to include a "xx time left" message during the last day of submissions.

@rixx rixx added size: small Easy and/or quick to do type: feature stage: up for grabs type: ux help wanted A default GitHub label inviting outside help good first issue A default GitHub label inviting first time contributors python Pull requests that update Python code javascript Pull requests that update Javascript code labels May 2, 2024
@SkylerBurger
Copy link
Contributor

Hello! I'd be happy to try adding this feature. I was able to set up the dev environment and poke around in the app, the docs are awesome by the way! I tried locating the proposal wizard mentioned in this issue's title but I don't think I found the right spot.

Screenshot 2024-05-08 140855

In the screencap above I am logged in as the superuser and viewing a proposal. It appears the title is already updated in the tab.

Screenshot 2024-05-08 141431

In this a screencap I'm logged in as a speaker with a proposal that has been associated to me. When viewing it, it appears the title of the site is already updated as shown in the browser tab.

Apologies if I am looking in the completely wrong location. If this isn't the spot referred to in the issue would it be possible to include some more information regarding the page the feature should be implemented? Thank you!

@rixx
Copy link
Member Author

rixx commented May 15, 2024

Thanks for taking a look at this! The "proposal wizard" is the multi step form that speakers have to go to to submit their proposal in the first place – sorry, that's a common internal naming in django-formtools for multistep forms, but I should have been clearer about this!

@SkylerBurger
Copy link
Contributor

I've added a PR for this issue and I'm happy to discuss any changes in scope or approach. I started with a simple JS approach before realizing this data might also be stored somewhere in a Django user session. I'm not super familiar with the user sessions but would be happy to look into it more if we want the proposal title to stay consistent in that browser tab throughout all of the remaining proposal wizard steps.

rixx added a commit that referenced this issue May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A default GitHub label inviting first time contributors help wanted A default GitHub label inviting outside help javascript Pull requests that update Javascript code python Pull requests that update Python code size: small Easy and/or quick to do stage: up for grabs type: feature type: ux
Projects
None yet
Development

No branches or pull requests

2 participants