Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently format WRAM values #288

Open
Rangi42 opened this issue Aug 19, 2020 · 0 comments
Open

Consistently format WRAM values #288

Rangi42 opened this issue Aug 19, 2020 · 0 comments

Comments

@Rangi42
Copy link
Member

Rangi42 commented Aug 19, 2020

macros/wram.asm uses db for one-byte values (like box_struct Species) and dw for two-byte values (like box_struct HPExp), leaving ds for larger values (like ds 3 for box_struct Exp) and free space. Meanwhile, wram.asm never uses dw and only uses db for wWaterRate and wWaterMons.

It could also use more UNIONs for overlapping values (like $60-byte wMonPartySpritesSavedOAM, $40-byte wTrainerCardBlkPacket, and many subsequent single bytes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant