Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common data in gflib is hard-coded #1739

Open
GriffinRichards opened this issue Aug 15, 2022 · 0 comments
Open

Common data in gflib is hard-coded #1739

GriffinRichards opened this issue Aug 15, 2022 · 0 comments

Comments

@GriffinRichards
Copy link
Member

GriffinRichards commented Aug 15, 2022 •
edited

It seems when gflib was created ramscrgen was not properly updated to support it, and it currently only considers src for COMMON. All the common symbols in gflib and their sizes are instead hard-coded in sym_common.txt.

As an aside (this has been brought up a few times), it'd be nice if ramscrgen handled alignment of common data and common_syms was removed.
DizzyEggg pushed a commit to DizzyEggg/pokeemerald that referenced this issue Aug 23, 2022
@AsparagusEduardo
Merge pull request pret#1739 from LOuroboros/primalReversionBE
d025364 
Implemented Primal Reversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GriffinRichards