Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some build artifacts are not in build/ #1224

Open
ExpoSeed opened this issue Oct 5, 2020 · 1 comment
Open

Some build artifacts are not in build/ #1224

ExpoSeed opened this issue Oct 5, 2020 · 1 comment

Comments

@ExpoSeed
Copy link
Contributor

ExpoSeed commented Oct 5, 2020 •
edited

The following build artifacts are placed in the same directory as the original.

  • sound/direct_sound_samples/*.bin
  • sound/songs/midi/*.s
  • *.1bpp
  • *.4bpp
  • *.8bpp
  • *.gbapal
  • *.lz
  • *.latfont
  • *.hwjpnfont
  • *.fwjpnfont
  • *.rl (not caught by make clean, see Add *.rl to make clean #1225)

They should be placed in build/ in the Makefile.
@GriffinRichards
Copy link
Member

.rl as well. That's not caught by make clean for some reason

@ExpoSeed ExpoSeed mentioned this issue Oct 6, 2020
Closed
@PikalaxALT PikalaxALT mentioned this issue Nov 6, 2020
Open
LOuroboros pushed a commit to LOuroboros/pokeemerald that referenced this issue Nov 15, 2020
@AsparagusEduardo
Merge pull request pret#1224 from AsparagusEduardo/BE-PECompat
fb8a6b4 
Fixed compatibility with Pokémon Expansion
ghoulslash pushed a commit to ghoulslash/pokeemerald that referenced this issue Mar 28, 2021
@AsparagusEduardo
Merge pull request pret#1224 from AsparagusEduardo/BE-PECompat
24839cc 
Fixed compatibility with Pokémon Expansion
@rawr51919 rawr51919 mentioned this issue Jun 19, 2022
Closed
@Icedude907 Icedude907 mentioned this issue Sep 4, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@GriffinRichards @ExpoSeed