Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Encore type matchup bug #936

Closed
wants to merge 1 commit into from
Closed

Document the Encore type matchup bug #936

wants to merge 1 commit into from

Conversation

rawr51919
Copy link
Contributor

@rawr51919 rawr51919 commented Jun 13, 2022

Document the type matchup bug that was discussed in #785 and touched upon in #784.
Fixes #785
Indirectly also fixes #784
This may be the result of Conversion2 itself, but would be appreciated if this were to be looked into further.

Document the type matchup bug that was discussed in #785 and touched upon in #784.
Actual comment used for documentation was in https://github.com/pret/pokecrystal/pull/784/files#diff-8cf500d6ca0f463d796e749bdae9b8ff1d6e3586224e764cdde0109db91dce99R1772=.
@rawr51919 rawr51919 marked this pull request as draft June 13, 2022 03:39
@rawr51919
Copy link
Contributor Author

Drafted until the root cause, whatever it is, is identified and the fix implemented into this PR

@vulcandth
Copy link
Collaborator

vulcandth commented Jun 13, 2022

Unless you plan on coming up with the solution.. their is little point in opening a PR for this as the Issue already exists. Other people can't work on this PR unless they are a maintainer... The PR should be opened by whoever comes up with the solution for the bug.

Not to discourage you from opening PR's.. but for example I can't contribute to this PR.. as i'm not a maintainer. So If I found a solution.. i'd have to contact you and wait for you to update your PR.

@rawr51919
Copy link
Contributor Author

rawr51919 commented Jun 13, 2022

Unless you plan on coming up with the solution.. their is little point in opening a PR for this as the Issue already exists. Other people can't work on this PR unless they are a maintainer... The PR should be opened by whoever comes up with the solution for the bug.

Not to discourage you from opening PR's.. but for example I can't contribute to this PR.. as i'm not a maintainer. So If I found a solution.. i'd have to contact you and wait for you to update your PR.

The reason for this PR is so that it has a better chance of it's true root cause being identified and a fix figured out for it. If you want to help with it, you could always suggest changes to the document itself with the new fix in question (ergo, same reason as #932)

@Rangi42
Copy link
Member

Rangi42 commented Jun 29, 2022

The reason for this PR is so that it has a better chance of it's true root cause being identified and a fix figured out for it.

That's what issues are for.

@Rangi42 Rangi42 closed this Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: AI_Smart_Encore can lead to incorrect type matchup checks
3 participants