Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTC overflow comment #1072

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaaaaa123456789
Copy link
Contributor

Fixes #1059

@Rangi42
Copy link
Member

Rangi42 commented Aug 16, 2023

From the issue:

also, the RTC overflow bit may want to be defined in constants/hardware_constants.asm

By the way, if you're going to define bit 6 for overflow, you might also want to define bit 7 for on/off.

Want to leave this open til those are ready?

@aaaaaa123456789
Copy link
Contributor Author

Sure, why not.

@Idain
Copy link
Contributor

Idain commented Dec 25, 2023

And so it was never resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad comment in RTC-checking code
3 participants