Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make worker configuration be different on each node #329

Open
kokosing opened this issue Mar 8, 2017 · 5 comments · May be fixed by #378
Open

Make worker configuration be different on each node #329

kokosing opened this issue Mar 8, 2017 · 5 comments · May be fixed by #378
Labels
enhancement

Comments

@kokosing
Copy link
Contributor

kokosing commented Mar 8, 2017

There are things in presto configuration which can be set differently on each node.

For example node.id in node.properties or node.internal-adress in config.properites.

The idea is to support template configuration where user could use some variables which will be resolved on target node. Let say we would have a defined set of variables like:

  • uuid - generates new uuid
  • current_node - a hostname (or ip address) used topology file for current node
  • coordinator - a hostname of coordinator node defined in topology file

then in configuration files user could have:

  • for config.properties:
http-server.http.port=28384
query.max-memory=50GB
query.max-memory-per-node=512MB
discovery.uri=http://${coordinator}:28384
coordinator=false
node.internal-address=${current_node}
  • for node.properties
node.id=${uuid}
catalog.config-dir=/etc/presto/catalog
node.data-dir=/var/lib/presto/data
node.environment=presto
node.launcher-log-file=/var/log/presto/launcher.log
node.server-log-file=/var/log/presto/server.log
plugin.dir=/usr/lib/presto/lib/plugin

@cawallin @rschlussel What do you think?
@rschlussel-zz
Copy link
Member

I think this is a duplicate of #35
It seems like s a valuable addition and the syntax you proposed is good.

Right now we special case the node.id. Because we generate a uuid on the node side if there's no node.id yet in the config file, but then for future deploys we specifically don't overwrite it so that the node names stay the same.

@kokosing kokosing mentioned this issue Mar 8, 2017
Closed
@kokosing
Copy link
Contributor Author

kokosing commented Mar 8, 2017

I closed the old one as this one is more detailed

@gorkemmulayim
Copy link
Contributor

Hello, I would like to work on this issue. Can you assign it to me?
It seems to me that allowing environment variable expansion in configuration files will solve the problem.

@kokosing
Copy link
Contributor Author

kokosing commented Feb 18, 2019 •
edited

Please go ahead. Nobody else is working on this right now.

@gorkemmulayim gorkemmulayim linked a pull request Feb 19, 2019 that will close this issue
Open
@prasannakumar109
Copy link

hai how to set the node.id in node.properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for expanding environment variables in configuration files. gorkemmulayim/presto-admin
4 participants
@kokosing @rschlussel-zz @gorkemmulayim @prasannakumar109